[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Performance regression in Quick Diff (0.9.32)

From: Brock Janiczak <brockj_at_tpg.com.au>
Date: 2005-08-03 12:20:10 CEST

Martin,
Excellent work. I had a quick look at your changes and they looked
really good. I will give your code a workout on the weekend

Don't worry about the resource variant thing. I was thinking of the
cached resource variant. Changing the base to not use a cached resource
variant would be difficult since it extends RemoteResoruce (which does
need to be cached).

cheers,
Brock

Martin Letenay wrote:

>Well,
>
>I've just commited the refactored BaseResource related code in r1488.
>It solved the performance regression (hitting server instead base copy).
>It also solved an issue when doing CompareWith>BaseRevision where diff was
>not able
>to find any particular difference and showed the whole contents as changed .
>I expected som minor performance gain too.
>
>So far I did not notice any new regressions, it seems to work at least as
>good as before.
>If you'll find some time and will, you can test it a bit too ...
>
>Regarding the issue of not using resource variants for things we have in
>base copies,
>I have to think through it carefully. I'm not sure whether it is feasible or
>good idea at all yet.
>I did not want to make too many changes at the same time, just fix the code
>we had so far.
>I'll investigate this idea later, I think there are some bugs waiting for me
>there ...
>
>Regards,
>Martin
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
>For additional commands, e-mail: dev-help@subclipse.tigris.org
>
>
>
>
>
Received on Wed Aug 3 20:20:10 2005

This is an archived mail posted to the Subclipse Dev mailing list.