[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] drag-n-drop into SVN History view

From: Brock Janiczak <brockj_at_tpg.com.au>
Date: 2005-07-23 02:17:49 CEST

Eugene,
I can't see anything wrong with your fix. It does look like a copy and
paste from CVS. SVN can handle IContainers just fine.
Applied patch as r1444.

Thanks!

Eugene Kuleshov wrote:

> Hi,
>
> I've noticed that drag-n-drop to SVN History view does not work for
> projects and folders.
>
> The fix is very simple. In a HistoryDropAdapter class the following
> method should not check the instance of IResource, so I've commented
> one line, which was probably copied from similar class from CVS plugin.
>
> public boolean performDrop(Object data) {
> if (data == null) return false;
> if(data instanceof IResource[]) {
> IResource[] sources = (IResource[])data;
> if (sources.length == 0) return false;
> IResource resource = sources[0];
> // ---> if (!(resource instanceof IFile)) return false;
> view.showHistory(resource, true /* fetch */);
> return true;
> } else if( data instanceof ISVNRemoteResource) {
> view.showHistory((ISVNRemoteResource) data, null); // true
> /* fetch */);
> return true;
> }
> return false;
> }
>
>
> regards,
> Eugene
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
> For additional commands, e-mail: dev-help@subclipse.tigris.org
>
>
>
Received on Sat Jul 23 10:17:49 2005

This is an archived mail posted to the Subclipse Dev mailing list.