Magnus and all,
I am sorry about the big delay. I will commit my patch today.
Regards,
Panagiotis
On Apr 5, 2005 5:53 PM, Mark Phippard <MarkP@softlanding.com> wrote:
>
> "Magnus Naeslund(w)" <mag@fbab.net> wrote on 04/05/2005 10:50:01 AM:
>
> >
> > Mark Phippard said:
> > > I had been waiting for Subversion 1.1.4 to come out. Now that it is,
> I
> > > will put together a Subclipse release today or tomorrow depending on
> my
> > > time.
> > >
> > > If you have something you plan on committing that you want in the
> release,
> > > please email me ASAP so I can wait for it.
> > >
> >
> > Well maybe this time it's is too narrow, but sometime I would like to
> > apply my "auto-add" functionality, but it hinges of of Panagiotis
> > "auto-share" patch. I know my last combined patch is working "good
> enough"
> > since we're running it in production and test as we speak. Also I think
> > my combined patch (auto-add ontop of auto-share) actually have them both
> > working, but since I'm not entirely sure how auto-share should work I
> > can't really say it's complete.
> >
> > But no-one has reviewed the code or answered the questions I had about
> if
> > I was doing stuff the right way (especially the gui<->core connection).
> > I know it scratches our itches, but I don't know if the code is up to
> > Subclipses code standard.
> >
> > So when I get the patch OK:ed from you guys I need to either wait for
> > Panagiotis patch to be applied so I can diff against that, or apply my
> > patch first so that Panagiotis can rediff against that...
>
> I was hoping that Panagiotis would review it. Also, he has commit
> authority so he can just commit both of them whenever he feels like it. As
> long as you both test that your patch does nothing to make Eclipse 3.0.x
> stop working, I do not have any objections.
>
> Mark
>
>
>
> _____________________________________________________________________________
> Scanned for SoftLanding Systems, Inc. by IBM Email Security Management
> Services powered by MessageLabs.
>
> _____________________________________________________________________________
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
> For additional commands, e-mail: dev-help@subclipse.tigris.org
>
>
--
Take back the web http://www.getfirefox.com
Received on Wed Apr 6 04:32:09 2005