Re: [PATCH v2] build/ac-macros/macosx.m4: workaround AC_RUN_IFELSE

Fabrice Fontaine wrote on Sun, 30 Aug 2020 17:24 +0200:
> The SVN_LIB_MACHO_ITERATE macro contains an AC_RUN_IFELSE test that
> doesn't work when cross-compiling.

Don't say "doesn't work"; describe the symptoms, error messages, etc..

> Signed-off-by: Thomas Petazzoni <thomas.petazzoni_at_bootlin.com>
> [Retrieved (and slightly updated following the suggestion of Nathan Hartman) from:
> https://git.buildroot.net/buildroot/tree/package/subversion/0002-workaround-ac-run-ifelse.patch]

We use different rfc822esque header names.

The URL will break as soon as you package a Subversion release to
which this patch will have been merged.

The outer parenthetical implies the v2 patch is the v1 patch plus
a "slight update" courtesy of Nathan. That implication is not accurate.

To address all these issues, how about:

[[[
Patch by: Fabrice Fontaine

Inspired by: Thomas Petazzoni
(See https://git.buildroot.net/buildroot/tree/package/subversion/0002-workaround-ac-run-ifelse.patch?h=2020.08-rc3)
]]]

Feel free to add "Suggested by" and "Review by" lines as you see fit.
Email addresses in the header values are supported, but not required.

("Inspired by" is supported by contribulyzer.)

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice_at_gmail.com>
> ---

> +++ b/build/ac-macros/macosx.m4
> @@ -38,7 +38,7 @@ AC_DEFUN(SVN_LIB_MACHO_ITERATE,
> AC_MSG_RESULT([yes])
> ],[
> AC_MSG_RESULT([no])
> - ])
> + ],[:])

Isn't that going to DTWT when cross-compiling for a macosx target? In
that case SVN_HAVE_MACHO_ITERATE should possibly be defined, but won't be.

> ])
Received on 2020-08-31 04:40:57 CEST