[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1878211 - in /subversion/branches/1.14.x: ./ STATUS subversion/libsvn_client/mtcc.c subversion/tests/cmdline/svnmucc_tests.py

From: Johan Corveleyn <jcorvel_at_gmail.com>
Date: Thu, 28 May 2020 09:20:57 +0200

On Thu, May 28, 2020 at 8:33 AM Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
>
> svn-role_at_apache.org wrote on Thu, 28 May 2020 04:00 -0000:
> > +++ subversion/branches/1.14.x/subversion/libsvn_client/mtcc.c Thu May 28 04:00:12 2020
> > @@ -453,7 +453,8 @@ mtcc_verify_create(svn_client__mtcc_t *m
> >
> > if (op)
> > return svn_error_createf(SVN_ERR_FS_ALREADY_EXISTS, NULL,
> > - _("Path '%s' already exists"),
> > + _("Path '%s' already exists, or was created "
> > + "by an earlier operation"),
> > new_relpath);
>
> Is "was created" in the correct tense? This error message is triggered
> before the RA session is opened, so it shouldn't imply that the earlier
> operation completed successfully.

Hmm, I completely "read over" that. But you're probably right: with
"casual user glasses" on, this might be misunderstood. Though I'm not
sure how to rephrase it to make it clear enough, yet remain succinct.

-- 
Johan
Received on 2020-05-28 09:21:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.