[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1868571 - /subversion/trunk/build/run_tests.py

From: Nathan Hartman <hartman.nathan_at_gmail.com>
Date: Fri, 18 Oct 2019 10:30:09 -0400

On Fri, Oct 18, 2019 at 4:52 AM Branko Čibej <brane_at_apache.org> wrote:

> >> - print("SUMMARY: %s, by the grace of Python %d.%d.%d.\n"
> >> - % (summary,
> >> - sys.version_info.major,
> >> - sys.version_info.minor,
> >> - sys.version_info.micro))
> >> + print("Python version: %d.%d.%d.\n" % sys.version_info[:3])
> >> + print(summary)
> >>
> >> self._close_log()
> >> return failed
> > I don't object to the changed message, but I do object to the missing
> > prefix "SUMMARY: " on the last line and the missing additional newline
> > on the same last line and the extra newline on the python version line.
> >
> > Should be:
> > print("SUMMARY: %s\n" % summary)
> >
> > and remove the trailing newline from the Python version line.
>

 Done in r1868596.

Looks like this:

$ make check TESTS=subversion/tests/cmdline/diff_tests.py
[1/1]
diff_tests.py......................................................success
Summary of test results:
  1 test PASSED
Python version: 2.7.10.
SUMMARY: All tests successful

$

Have a nice day :-)
Nathan
Received on 2019-10-18 16:30:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.