[Moved to dev@]
On 18.10.2019 09:22, Branko Čibej wrote:
> On 18.10.2019 06:39, danielsh_at_apache.org wrote:
>> Author: danielsh
>> Date: Fri Oct 18 04:39:08 2019
>> New Revision: 1868571
>>
>> URL: http://svn.apache.org/viewvc?rev=1868571&view=rev
>> Log:
>> * build/run_tests.py
>> (TestHarness.run): Tweak new output.
>>
>> Modified:
>> subversion/trunk/build/run_tests.py
>>
>> Modified: subversion/trunk/build/run_tests.py
>> URL: http://svn.apache.org/viewvc/subversion/trunk/build/run_tests.py?rev=1868571&r1=1868570&r2=1868571&view=diff
>> ==============================================================================
>> --- subversion/trunk/build/run_tests.py (original)
>> +++ subversion/trunk/build/run_tests.py Fri Oct 18 04:39:08 2019
>> @@ -716,11 +716,8 @@ class TestHarness:
>> summary = "Some tests failed"
>> else:
>> summary = "All tests successful"
>> - print("SUMMARY: %s, by the grace of Python %d.%d.%d.\n"
>> - % (summary,
>> - sys.version_info.major,
>> - sys.version_info.minor,
>> - sys.version_info.micro))
>> + print("Python version: %d.%d.%d.\n" % sys.version_info[:3])
>> + print(summary)
>>
>> self._close_log()
>> return failed
> I don't object to the changed message, but I do object to the missing
> prefix "SUMMARY: " on the last line and the missing additional newline
> on the same last line and the extra newline on the python version line.
>
> Should be:
> print("SUMMARY: %s\n" % summary)
>
> and remove the trailing newline from the Python version line.
>
> -- Brane
>
Received on 2019-10-18 10:52:33 CEST