Nathan Hartman wrote on Thu, 10 Oct 2019 17:36 +00:00:
> On Thu, Oct 10, 2019 at 1:15 PM Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> >
> > Nathan Hartman wrote on Thu, Oct 10, 2019 at 10:24:28 -0400:
> > > * Documentation:
> > >
> > > - SVN-3914 - INSTALL: document how to compile with libmagic on
> > > Windows.
> > > https://issues.apache.org/jira/browse/SVN-3914?issueNumber=3914
> >
> > This is a subtask of the next one, isn't it?
>
> I separated them because one is documentation, the other is Python
> programming. I tried to keep things organized by skill set. Also SVN-3914
> didn't actually include updating the scripts (unless I missed something).
>
> Should these be re-merged into one item, as you had it before?
That depends. _Do_ the Windows build scripts support libmagic?
If they do, then it's a documentation task and the Python task should be
deleted (as already done).
If they don't, then it's a Python task and the documentation task should
be merged into it; whoever implements it will be expected to document it
as well.
> > > We'll be happy to provide whatever guidance we can, as well as review
> > > and (hopefully) apply some quality patches!
> > >
> >
> > I wonder how many participants we're excluding here just by using a dated
> > expression such as "apply patches", as opposed to "merge a pull request"… ;-)
>
> Is applying a patch really such a strange concept these days? I
> participate in some projects that use Git and take as many patches as
> they do pull requests.
>
> We can include the github link but there was a whole discussion here
> about how pull requests were sitting there untouched, and there was no
> clean way to accept them and have them marked as such. Has that been
> fixed? If not, I'd rather avoid the confusion that would cause. Let me
> know...
Sure, there's no point in recommending a patch submission channel that's
not easy for us to work with. However, there's a third option: post the
github link but ask patches to be emailed. (We should probably just add
the link to HACKING, though, in that case; it's not specific to this event.)
Cheers,
Daniel
Received on 2019-10-10 19:48:40 CEST