[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1850781 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/blame.c libsvn_client/deprecated.c

From: Stefan Kueng <tortoisesvn_at_gmail.com>
Date: Tue, 8 Jan 2019 20:28:00 +0100

On 08.01.2019 19:58, Branko Čibej wrote:
> On 08.01.2019 19:45, steveking_at_apache.org wrote:
>> Author: steveking
>> Date: Tue Jan 8 18:45:45 2019
>> New Revision: 1850781
>>
>> URL: http://svn.apache.org/viewvc?rev=1850781&view=rev
>> Log:
>> Extend the blame callback with a string length parameter.
>>
>> * subversion/incluce/svn_client.h
>> * subversion/libsvn_client/blame.c
>> (svn_client_blame_receiver4_t): typedef for new callback
>> (svn_client_blame6): new API using the svn_client_blame_receiver4_t callback
>> * subversion/libsvn_client/deprecated.c
>> (svn_client_blame5): moved API there, calling svn_client_blame6 using a
>> callback shim
>> (blame_wrapper_receiver3): callback shim for svn_client_blame5
>>
>> Modified:
>> subversion/trunk/subversion/include/svn_client.h
>> subversion/trunk/subversion/libsvn_client/blame.c
>> subversion/trunk/subversion/libsvn_client/deprecated.c
>>
>> Modified: subversion/trunk/subversion/include/svn_client.h
>> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_client.h?rev=1850781&r1=1850780&r2=1850781&view=diff
>> ==============================================================================
>> --- subversion/trunk/subversion/include/svn_client.h (original)
>> +++ subversion/trunk/subversion/include/svn_client.h Tue Jan 8 18:45:45 2019
>> @@ -736,10 +736,11 @@ typedef svn_error_t *(*svn_client_get_co
>> * @{
>> */
>>
>> -/** Callback type used by svn_client_blame5() to notify the caller
>> +/** Callback type used by svn_client_blame6() to notify the caller
>> * that line @a line_no of the blamed file was last changed in @a revision
>> * which has the revision properties @a rev_props, and that the contents were
>> - * @a line.
>> + * @a line. The @a line content is delivered as is. It is up to the client to
>> + * determine the encoding. The line does not contain the cr/lf at the end.
>
> I don't think we even care about CR, only LF.

when splitting the line, but I never got a CR either in the callback, so
it is removed.

Stefan
Received on 2019-01-08 20:28:12 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.