Re: Subversion Exception!

From: Julian Foad <julianfoad_at_apache.org>
Date: Thu, 13 Dec 2018 15:05:30 +0000

Johan Corveleyn wrote:
> Just thinking out loud here, but could we perhaps log the
> non-canonical value as part of the assertion output?
> [...]
> something like
>
> line 10238: assertion failed
> (svn_dirent_is_absolute(local_abspath='C:ImNotCanonical'))

Yes, Johan, we could do that.

The attached patch demonstrates it working.

Test output:
[[[
$ subversion/tests/libsvn_wc/wc-test 1
...
svn_tests: E235000: In file '.../subversion/libsvn_wc/wc_db.c' line 10238: assertion failed (svn_dirent_is_absolute(local_abspath='C:ImNotAbsolute'))
...
]]]

-- 
- Julian

text/x-patch attachment: assert-dirent-absolute-1.patch

Received on 2018-12-13 16:05:38 CET

This message: [ Message body ]
Next message: Johan Corveleyn: "Re: Subversion Exception!"
Previous message: Branko Čibej: "Re: Subversion Exception!"
In reply to: Johan Corveleyn: "Re: Subversion Exception!"
Next in thread: Johan Corveleyn: "Re: Subversion Exception!"
Reply: Johan Corveleyn: "Re: Subversion Exception!"
Reply: Bert Huijben: "Re: Subversion Exception!"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]