[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Subversion Exception!

From: Johan Corveleyn <jcorvel_at_gmail.com>
Date: Thu, 13 Dec 2018 14:15:25 +0100

On Wed, Dec 12, 2018 at 10:23 PM Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> Stefan Kueng wrote on Wed, 12 Dec 2018 21:16 +0100:
> > And as I repeatedly said: TSVN does validate the input as good as it
> > can. But if svn does neither describe the *exact* specs in the docs nor
> > provide any APIs that do that, then TSVN has to guess.
> > And no: specifying that paths/uris have to be "canonicalized" is not
> > enough because I do that, using the svn APIs.
> > So apparently that's not enough.
>
> Stefan, there is nothing we can do with this information. If you have
> found a value for which svn_foo_is_canonical(svn_foo_canonicalize(value))
> returns false, please tell us what that value is.

Just thinking out loud here, but could we perhaps log the
non-canonical value as part of the assertion output?
Instead of:

  line 10238: assertion failed (svn_dirent_is_absolute(local_abspath))

something like

 line 10238: assertion failed
(svn_dirent_is_absolute(local_abspath='C:ImNotCanonical'))

That way, we would at least have some concrete information ...

-- 
Johan
Received on 2018-12-13 14:15:55 CET

This is an archived mail posted to the Subversion Dev mailing list.