[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

From: Julian Foad <julianfoad_at_apache.org>
Date: Fri, 30 Nov 2018 08:44:29 +0000

Hello Sergey!

Your patch was filed as issue #4729
    https://issues.apache.org/jira/browse/SVN-4729
and released in Subversion 1.10
    https://subversion.apache.org/docs/release-notes/1.10.html#dump-include-exclude

A user has reported a problem with this feature.
    https://issues.apache.org/jira/browse/SVN-4760

It looks like when the source of a copied directory is excluded, it is only adding the directory itself and not adding the directory's contents. That sounds to me like a bug -- it is not the behaviour I would expect.

I see that the regression tests only test with an empty source directory.
    subversion/tests/cmdline/svnadmin_tests.py : dump_exclude_copysource() etc.

Are you able to investigate this?

-- 
- Julian
Sergey Raevskiy wrote on 2016-10-12:
> I've attached a patch that adds '--include/--exclude' options to 'svnadmin
> dump'. These options work similarly to 'svndumpfilter include/exclude'
> but provide proper handling of 'copy from' paths.
> [...]
Received on 2018-11-30 09:44:38 CET

This is an archived mail posted to the Subversion Dev mailing list.