Re: [swig-py3][patch] interfacing bytes object instead of str

On Wed, Nov 28, 2018, 10:40 AM Daniel Shahaf <d.s_at_daniel.shahaf.name wrote:

> Yasuhito FUTATSUKI wrote on Tue, Nov 27, 2018 at 06:50:46 +0900:
> > I've revised typemaps and APIs using svn_stringbuf_t *, then I found
> > almost all those APIs include svn_stream_readline() use svn_stringbuf_t
> > for file contents. So I've modified typemaps again so that those APIs
> > use bytes for svn_stringbuf_t interface.
> >
> > The patch below destined for branches/swig-py affects those API wrappers.
>
> Thanks for the patch, Yasuhito. It looks good on a quick skim. Troy,
> you've
> worked on this branch before; would you perchance be able to review this?
> (If you can, great; but no worries if you can't)
>

I'll definitely try to do so. I had even starred this patch to review
already, but obviously haven't actually looked over it yet. ;)

Troy

>
Received on 2018-11-28 16:54:00 CET