[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn/conflict-callbacks.c indentation fix

From: Branko Čibej <brane_at_apache.org>
Date: Fri, 2 Nov 2018 11:42:07 +0100

On 02.11.2018 11:33, James McCoy wrote:
> On Fri, Nov 02, 2018 at 11:08:10AM +0100, Stefan Sperling wrote:
>> On Fri, Nov 02, 2018 at 10:49:23AM +0100, Branko Čibej wrote:
>>> On 02.11.2018 10:44, Stefan Sperling wrote:
>>>> I confirm that your patch is correct. I mis-indented these blocks.
>>> Time to start using a real editor, I guess? :)
>> The further I progress into adulthood, the more our tiny indentation
>> by two spaces seems to be causing me trouble...
>> Maybe(we) could have another (historical) vote, on tabs vs spaces this time?
>> Disclaimer: I'd vote for tabs :)
> Or always use {}, even for 1 line blocks.

No space after bang! No space after bang! Ye who write 'if (! foo) ...'
with a space after the bang shall be forever cast into the void! Yaargh!

-- Brane

P.S.: This is shaping up to become a fun thread, heh heh.
Received on 2018-11-02 11:42:16 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.