[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn/conflict-callbacks.c indentation fix

From: James McCoy <jamessan_at_jamessan.com>
Date: Fri, 2 Nov 2018 06:33:25 -0400

On Fri, Nov 02, 2018 at 11:08:10AM +0100, Stefan Sperling wrote:
> On Fri, Nov 02, 2018 at 10:49:23AM +0100, Branko Čibej wrote:
> > On 02.11.2018 10:44, Stefan Sperling wrote:
> > > I confirm that your patch is correct. I mis-indented these blocks.
> >
> > Time to start using a real editor, I guess? :)
>
> The further I progress into adulthood, the more our tiny indentation
> by two spaces seems to be causing me trouble...
>
> Maybe(we) could have another (historical) vote, on tabs vs spaces this time?
> Disclaimer: I'd vote for tabs :)

Or always use {}, even for 1 line blocks.

Cheers,

-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB
Received on 2018-11-02 11:33:37 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.