[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

msguniq in po-update.sh

From: Mattias EngdegÄrd <mattiase_at_acm.org>
Date: Sun, 23 Sep 2018 23:06:40 +0200

Sorry about messing up the build with my ill-considered merge of r1841318 (sv.po). Instead of attempting to merge from 1.11.x, which is what caused the duplicated msgids, I should just have copied the entire file from that branch and be done with it. That was just careless on my part.

However, r1841716 and r1841717 (adding msguniq to po-update.sh and running it) may have been made in haste. The latter reformatted the entire file, making it impossible to see what had actually changed; I had to write a script to normalise the strings in order to make sense of that change, and the line history is completely gone.

I'll replace sv.po in trunk with that in 1.11.x, which does not contain any duplicated msgids. Would you agree to revert r1841716, on the grounds that having msguniq as part of the script is somewhat invasive and dangerous? Not only does it reformat the file, but I'm far from sure what it does with duplicated msgids, and whether that is the right course of action in all cases. Surely human intervention is safer.

By the way, my thanks to Julian Foad for mending another of my mistakes (missing newlines). These errors are usually linted out prior to committing; I have no excuse for not doing that.
Received on 2018-09-23 23:07:01 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.