Re: FSFS recovery should prune rep-cache even if its use is disabled
From: Julian Foad <julianfoad_at_apache.org>
Date: Thu, 23 Aug 2018 09:59:41 +0100
Daniel Shahaf wrote:
I just noticed that https://issues.apache.org/jira/browse/SVN-4214 says "Recover should not operate on rep-cache.db if rep-caching is disabled" in its description. At first I misread that line as "Recover should not create rep-cache.db ..." like the issue's summary.
Philip, can you recall anything that might help re-evaluate this now?
> I assume, going by that comment, that Philip's reason for changing the
But in the new inner block, __del_rep_reference() isn't called if rep-cache.db doesn't exist, so it can't create it.
> > > If "recovery" while re-sharing is disabled (by the fsfs.conf setting)
It can potentially lead to data loss, so we should backport to 1.9 as well.
-- - JulianReceived on 2018-08-23 10:59:50 CEST
This is an archived mail posted to the Subversion Dev mailing list.