Re: FSFS recovery should prune rep-cache even if its use is disabled

Julian Foad wrote on Wed, 22 Aug 2018 22:20 +0100:
> Julian Foad wrote:
> > It looks like r1213716 ("also prune the rep-cache when it's present but
> > reportedly not being used") was reverted by r1367674, apparently
> > unintentionally.
>
> Well, with some degree of intention, judging by the code comment having
> been adjusted accordingly, but with no reason given and no mention in
> https://issues.apache.org/jira/browse/SVN-4214 .
>

I assume, going by that comment, that Philip's reason for changing the
condition was that svn_fs_fs__del_rep_reference() would create an empty
rep-cache.db if it was called when (ffd->format >= SVN_FS_FS__MIN_REP_SHARING_FORMAT
&& ffd->rep_sharing_allowed == FALSE).

> > If "recovery" while re-sharing is disabled (by the fsfs.conf setting)
> > leaves future revision entries in the rep-cache, then later re-enabling
> > the rep-cache could cause serious corruption if those entries are then
> > used.
> >
> > Therefore I think we should repeat r1213716 as a bug fix.
> >
> > WDYT?

+1, no question about it. Or rather, I think the question is whether to
backport it only to 1.10 or also to 1.9...

Cheers,

Daniel
Received on 2018-08-23 00:06:53 CEST