[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: "svn diff" doesn't work correctly if a file is replaced with a symlink locally

From: Julian Foad <julianfoad_at_apache.org>
Date: Fri, 20 Jul 2018 11:46:56 +0100

Julian Foad wrote:
> Daniel Shahaf wrote:
> > Dmitry Pavlenko wrote on Thu, Jul 19, 2018 at 19:03:30 +0200:
> > > I'm not 100% sure that [...] is the expected output [...]
[...]
> > I suggest that we add a regression test that simply expects any output [...]

But on Windows the buildbots have discovered that this 'diff' command does not error out, and so this test gives an XPASS result (which we choose to treat as an overall failure of the test suite).

What to do? Add in some reasonable expectation?

We need to design the expectation.

Intuitively I expect a replacement of file with symlink to be presented as file deleted and symlink added, not as a content-modification (from normal file content to the 'special' representation of the symlink).

Does that make sense, anyone? Does that fit with our architecture whereby knowledge of 'special files' is client-side?

Presumably we would want a diff requested by the client to behave the same way, regardless whether the two items being diffed are located on the server and/or on the client. In contrast, if we request a diff through a server-layer tool such as 'svnadmin' then presumably it must display a content-modification and property-modification, because it is looking at the server-side representation of a symlink (using a 'special file').

How does this fit with our ideas of object lifelines? Was that a replacement, starting a new lifeline, or not?

-- 
- Julian
Received on 2018-07-20 12:47:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.