[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: "svn diff" doesn't work correctly if a file is replaced with a symlink locally

From: Julian Foad <julianfoad_at_apache.org>
Date: Fri, 20 Jul 2018 10:30:11 +0100

Daniel Shahaf wrote:
> Dmitry Pavlenko wrote on Thu, Jul 19, 2018 at 19:03:30 +0200:
> > I'm not 100% sure that [...] is the expected output [...]
> There isn't a patch flying around that produces this output, right?

No, there isn't yet.

> I suggest that we add a regression test that simply expects any output [...]
> There should be an "@XFail()" decorator [...]
> Since this test doesn't commit, it can pass read_only=True [...]
> Please don't add new instances of backslash-space [...]

I made those tweaks and committed it:

Thanks for the patch!

- Julian
Received on 2018-07-20 11:30:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.