[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix libsvn_auth_gnome_keyring.pc w/libsecret

From: Joe Orton <jorton_at_redhat.com>
Date: Thu, 3 May 2018 10:35:50 +0100

On Wed, May 02, 2018 at 04:32:26PM +0100, Philip Martin wrote:
> Philip Martin <philip_at_codematters.co.uk> writes:
> >> Fixes libsvn_auth_gnome_keyring.pc when configured with libsecret, and
> >> make dependencies private.
> >
> > Looks OK to me.
> Perhaps we should delete the .pc files for gnome/kwallet auth libraries.
> The corresponding libraries do not really have a public API and I think
> nodody will ever attempt to link against them. In Subversion the
> libraries are loaded at runtime using APR's DSO functions so even we do
> not link against them.

I thought about that, but the SVN buildsystem is building & installing
them like libraries not like DSOs (which should be linked with libtool's
-module argument and not installed directly in $libdir), and there are
symbols exposed in the headers like svn_auth_gnome_keyring_version().
So it looks a bit weird if they are really not intended to be used as

Regards, Joe
Received on 2018-05-03 11:36:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.