[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix libsvn_auth_gnome_keyring.pc w/libsecret

From: Stefan Sperling <stsp_at_apache.org>
Date: Thu, 3 May 2018 10:13:52 +0200

On Thu, May 03, 2018 at 09:11:33AM +0100, Philip Martin wrote:
> Philip Martin <philip_at_codematters.co.uk> writes:
>
> > Philip Martin <philip_at_codematters.co.uk> writes:
> >
> >>> Fixes libsvn_auth_gnome_keyring.pc when configured with libsecret, and
> >>> make dependencies private.
> >>
> >> Looks OK to me.
> >
> > Perhaps we should delete the .pc files for gnome/kwallet auth libraries.
> > The corresponding libraries do not really have a public API and I think
> > nodody will ever attempt to link against them. In Subversion the
> > libraries are loaded at runtime using APR's DSO functions so even we do
> > not link against them.
>
> We should probably remove the .pc files for anything that doesn't have a
> public API, i.e. the RA backends, the FS backends and fs_util in
> addition to gnome/kwallet auth libraries.

+1
Received on 2018-05-03 10:14:24 CEST

This is an archived mail posted to the Subversion Dev mailing list.