On Wed, Nov 29, 2017, 10:08 AM Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> troycurtisjr_at_apache.org wrote on Wed, 29 Nov 2017 03:50 +0000:
> > Author: troycurtisjr
> > Date: Wed Nov 29 03:50:09 2017
> > New Revision: 1816596
> >
> > URL: http://svn.apache.org/viewvc?rev=1816596&view=rev
> > Log:
> > On branch swig-py3: Fix clean-swig-py for out-of-source builds.
> >
> > * Makefile.in
> > (EXTRACLEAN_SWIG_PY): Change SWIG_PY_SRC_DIR to SWIG_PY_DIR to
> correctly
> > reference generated files in out-of-source builds.
>
> Shouldn't this go to trunk?
>
Probably, but eventually I hope the whole branch will make it to trunk. :)
Had it been something really functional I might have thought to put it in
trunk, as it was it was merely incidental to me tracking down the remaining
py3 issues (while still being directly related to my swig-py3 efforts). I
noticed it since running 'make clean-swig-py' didn't *clean* my swig py
files! It obviously hasn't caused too much heartburn, since that line has
been there since 2005 (r857571) :)
But if you think it should go ahead and get put to trunk I'd be happy to do
so, you may be worried that I'm dragging this swig-py3 branch thing out :P
> While reviewing this I noticed that
> subversion/bindings/swig/proxy/svn_*.swg
> are created in the source dir rather than in the build dir. I suspect
> that might be a bug but I'm not familiar enough with these swig details.
>
>
Since I've been working in this area, I'll take a look and add a fix as
necessary.
Thanks!
Troy
Received on 2017-11-30 03:20:30 CET