[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1816069 - /subversion/branches/1.8.x-issue4707/subversion/svnrdump/dump_editor.c

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Wed, 22 Nov 2017 20:59:12 +0300

Julian Foad <julianfoad_at_apache.org> writes:

> - ": %lu\n",
> - (unsigned long)info->size));
> + ": %" APR_SIZE_T_FMT "\n",
> + info->size));

I think that using APR_SIZE_T_FMT would still lead to the same issue with
large file sizes in the 32-bit environment (where size_t is also 32 bit).

Perhaps, the code should be using APR_OFF_T_FMT as the format specifier?

(The apr_file_info_t.size value is an apr_off_t)

Regards,
Evgeny Kotkov
Received on 2017-11-22 18:59:39 CET

This is an archived mail posted to the Subversion Dev mailing list.