Re: Error E140001: Sum of subblock sizes larger than total block content length
From: Julian Foad <julianfoad_at_apache.org>
Date: Wed, 22 Nov 2017 15:36:12 +0100
> *From:* Ronald Taneza [mailto:ronald.taneza_at_gmail.com]
Thank you for finding this!
I can see this bug existed in svnrdump up to 1.8.19. (For 1.9 I refactored this to use common code shared with 'svnadmin dump' which does not have this bug.)
In 1.8.19, subversion/svnrdump/svnrdump.c:close_file() contains:
if (fb->dump_text)
info->size is apr_off_t ... probably 64 bits on most systems.
It uses "%lu" for the text content, which thus work OK up to 4 GB, and "%ld" for the overall content length which thus only works up to 2 GB.
Earlier in this file, the property content length is printed correctly:
buf = apr_psprintf(pool, SVN_REPOS_DUMPFILE_CONTENT_LENGTH
The attached patch should fix it; not yet tested.
- Julian
|
This is an archived mail posted to the Subversion Dev mailing list.
This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.