Re: svn commit: r1814386 - in /subversion/branches/swig-py3: build/generator/swig/ build/generator/util/ subversion/bindings/swig/python/svn/ subversion/bindings/swig/python/tests/ subversion/bindings/swig/python/tests/trac/versioncontrol/ subversion/bindi...

troycurtisjr_at_apache.org wrote on Mon, 06 Nov 2017 01:58 +0000:
> +++ subversion/branches/swig-py3/subversion/bindings/swig/python/tests/trac/versioncontrol/tests/svn_fs.py Mon Nov 6 01:58:20 2017
> @@ -53,17 +53,19 @@ import shutil
> if sys.version_info[0] >= 3:
⋮
> else:
> # Python <3.0
> try:
> - from cStringIO import StringIO
> + from io import StringIO
> except ImportError:
> - from StringIO import StringIO
> + from io import StringIO

Is this intended to catch transient disk errors or something? :-)

> @@ -246,21 +249,21 @@ class SubversionRepositoryTestCase(unitt
> diffs = self.repos.get_deltas('trunk/README.txt', 2, 'trunk/README.txt', 3)
> self._cmp_diff((('trunk/README.txt', 2),
> ('trunk/README.txt', 3),
> - (Node.FILE, Changeset.EDIT)), diffs.next())
> - self.assertRaises(StopIteration, diffs.next)
> + (Node.FILE, Changeset.EDIT)), next(diffs))
> + self.assertRaises(StopIteration, lambda *args: next(diffs))

Should this be "lambda: next(diffs)" without variadicity?

>

Ack on the rest.

Cheers,

Daniel
Received on 2017-11-06 14:33:35 CET