[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: How to manage PR's

From: Julian Foad <julianfoad_at_apache.org>
Date: Wed, 11 Oct 2017 13:42:30 +0100

Johan Corveleyn wrote:
> On Tue, Oct 10, 2017 at 8:11 PM, asfgit <git_at_git.apache.org> wrote:
>> Github user asfgit closed the pull request at:
>> https://github.com/apache/subversion/pull/6
> Anybody knows why asfgit closed the PR?

It was because I committed the patch (r1811752) and included "This
closes #6" in the log message.

> I've clicked on the above hyperlink, and saw some comments made by
> Julian (11 hours ago) and by the submitter (8 hours ago), but these
> comments are not visible on dev@. Shouldn't those be synced back here
> somehow? Or how should we handle PR's, preferably with a process
> that's still centered around the dev@ mailinglist?

As others have noted, the 'integration' with Github is primitive. I
raised ASF-infra ticket
https://issues.apache.org/jira/browse/INFRA-15015 "Pull-request replies
sent to dev@ not getting through to GitHub" where Daniel Gruno wrote:

"The feature is currently not in a working condition (it relied on an
old FreeBSD setup). I have removed the misleading hint from future
GitHub emails. We may revisit and re-enable in the future, but at
present, it is not a service feature we offer any longer."

And now I see that not even PR follow-up messages from the GH side are
coming through.

> If we can't really handle PR's well, maybe we shouldn't allow them
> (i.e. indicate this on github somehow, that it's just a mirror and we
> won't accept PR's, but expect patch submissions on dev@ instead)?

I would love it if we could set up an integration that worked. I've been
thinking to locate the other ASF people who are interested and join them.

Another thought: Maybe GitLab or Assembla would be easier to start with
than GitHub. Here's an svn mirror on GitLab, that I set up:


GitLab allows PRs to be turned off in its standard configuration
settings, so I've done that. I haven't looked at all into integrating
with ASF mailing lists.

- Julian
Received on 2017-10-11 14:42:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.