[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: How to manage PR's (was: [GitHub] subversion pull request #6: VC should be 14.1 and not 15.0)

From: James McCoy <jamessan_at_jamessan.com>
Date: Tue, 10 Oct 2017 21:06:42 -0400

On Wed, Oct 11, 2017 at 12:51:34AM +0000, Daniel Shahaf wrote:
> Stefan Sperling wrote on Tue, 10 Oct 2017 23:44 +0200:
> > Couldn't some automated process mail PRs from github as (--git) diffs to dev@?
>
> Moreover, if the submitter's commits have a valid email address on them
> (and the domain doesn't use strict SPF records), that automated process
> can even set the "From:" header to the submitter's from address, so
> replies go to him via email directly.
>
> But the thing is, github _already_ has a bidirectional email gateway for
> PRs, it's part of their service. And it works even for people who don't
> use a valid email address on commits. Maybe we can reuse that somehow?

Christian Brabandt (@chrisbra) setup something like that for Vim. If I
recall correctly, he created a dedicated account and had it receive all
notifications for the vim/vim repository. That account then forwards to
the vim-dev list. Since all notifications have GitHub's usual reply
email, people are able to reply and have it show up on GitHub.

However, there has also been various problems with it. Sometimes when a
user comments directly on GitHub, the list email shows up as from
someone else. Sometimes the list responses show up on GitHub as
"vim-dev ml" instead of the actual user. Sometimes list users reply
only to the list instead of keeping GitHub in the loop, so then you've
lost the flow of the discussion.

It's not possible to disable pull requests on GitHub repos, even when
GitHub knows it is a "mirror" repository. If there's not a good way to
integrate the discussion between the list and PRs (which seems to be the
case from my experience with Vim), I'd be in favor of disabling the
repo.

Cheers,

-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB
Received on 2017-10-11 03:06:55 CEST

This is an archived mail posted to the Subversion Dev mailing list.