[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Use consistent HTTP connection setup code throughout test suite

From: Stefan <luke1410_at_posteo.de>
Date: Fri, 17 Feb 2017 01:52:47 +0100

Hi Kotkov,

On 2/16/2017 21:44, Evgeny Kotkov wrote:
> Stefan Hett <luke1410_at_posteo.de> writes:
>
>> Committed in r1782893 with a slightly modified log message.
>> - loc = urlparse(req_url)
>> -
>> - if loc.scheme == 'http':
>> - h = httplib.HTTPConnection(loc.hostname, loc.port)
>> - else:
>> - h = httplib.HTTPSConnection(loc.hostname, loc.port)
>> + h = svntest.main.create_http_connection(req_url)
> Hi Stefan,
>
> The create_http_connection() function also accepts a 'debuglevel', which
> defaults to full debug output. The code before this change didn't enable
> debugging for the HTTP connections, but now it does, and this makes
>
> win-tests.py -t mod_authz_svn_tests.py --log-to-stdout
>
> pretty much unusable.
>
> Perhaps, it would be better to pass debuglevel=0 here to match the
> original behavior?
Thanks for taking the time to review the commit.

The other usages of the function (see lock_tests.py and
mod_dav_svn_tests.py) already use the default debuglevel. If the
--log-to-stdout output is too noisy with the debuglevel being set to 9,
shouldn't these be changed as well?

For now I've restored the previous behavior in r1783324 and set the
debuglevel back to 0 for the caller in mod_authz_svn_tests.py, restoring
its previous behavior as per your suggestion.

Regards,
Stefan

Received on 2017-02-17 01:53:05 CET

This is an archived mail posted to the Subversion Dev mailing list.