Re: [PATCH] Use consistent HTTP connection setup code throughout test suite

Stefan Hett <luke1410_at_posteo.de> writes:

> Committed in r1782893 with a slightly modified log message.

> - loc = urlparse(req_url)
> -
> - if loc.scheme == 'http':
> - h = httplib.HTTPConnection(loc.hostname, loc.port)
> - else:
> - h = httplib.HTTPSConnection(loc.hostname, loc.port)
> + h = svntest.main.create_http_connection(req_url)

Hi Stefan,

The create_http_connection() function also accepts a 'debuglevel', which
defaults to full debug output. The code before this change didn't enable
debugging for the HTTP connections, but now it does, and this makes

  win-tests.py -t mod_authz_svn_tests.py --log-to-stdout

pretty much unusable.

Perhaps, it would be better to pass debuglevel=0 here to match the
original behavior?

Regards,
Evgeny Kotkov
Received on 2017-02-16 21:45:19 CET