Re: [PATCH] add SMTP SSL capability to mailer

On 22/12/16, João M. S. Silva wrote:
> [I'm not subscribed to the list, please CC me.]
>
> I've discussed this patch with Daniel Shahaf in the users mailing list.
>
> This patch makes it possible to use e.g. Gmail's SMTP to send
> post-commit messages (using SSL).
Looks good to me, in general; I haven't tested it.

Just a minor issue: when processing other "option = yes" kind of config options, the script doesn't convert to lower case before testing its value, so I suggest to remove ".lower()", for consistency.

- Julian
Received on 2017-01-05 11:35:41 CET