[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix number of array elements

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Wed, 12 Oct 2016 13:16:47 +0200

On 12 October 2016 at 12:58, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
> On 12 October 2016 at 12:48, Stefan <luke1410_at_gmx.de> wrote:
>> Hi,
>>
>> hope this patch is correct... As far as I see the number of elements is
>> off by one here:
>>
>> [[[
>> Allocate the correct number of element entries.
>>
>> * subversion/libsvn_client/conflicts.c
>> (svn_client_conflict_text_get_resolution_options): Correct number of array
>> entires.
>> ]]]
> I think that log message could be improvement: because this not the
> number of how many entries is allocated. This is initial size of
> array, and apr_array will expand it if needed.
>
I've tweaked log message and committed change in r1764439. Thanks.

-- 
Ivan Zhakov
Received on 2016-10-12 13:17:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.