[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix number of array elements

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Wed, 12 Oct 2016 12:58:21 +0200

On 12 October 2016 at 12:48, Stefan <luke1410_at_gmx.de> wrote:
> Hi,
>
> hope this patch is correct... As far as I see the number of elements is
> off by one here:
>
> [[[
> Allocate the correct number of element entries.
>
> * subversion/libsvn_client/conflicts.c
> (svn_client_conflict_text_get_resolution_options): Correct number of array
> entires.
> ]]]
I think that log message could be improvement: because this not the
number of how many entries is allocated. This is initial size of
array, and apr_array will expand it if needed.

PS: Please submit patches with text/plain mime type as recommended in
Community Guide [1]
[1] https://subversion.apache.org/docs/community-guide/general.html#patches-submission

-- 
Ivan Zhakov
Received on 2016-10-12 12:58:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.