RE: [PATCH] Re: ra_local doesn't report post-commit errors
From: Bert Huijben <bert_at_qqmail.nl>
Date: Tue, 20 Sep 2016 11:48:47 +0200
> -----Original Message-----
I remember that we already put some comments there... But usually the api user implements both svn_commit_callback2_t and the processing of the result of close_edit(). The problem in libsvn_client is more subtle, because the standard implementation is shared between many code locations.
> 2. The commit callback can fail even when the commit succeeded, for
Yes... it can always break... but usually the implementation knows their own scenarios. The current code explicitly ignores certain errors to allow the client side post commit processing to occur anyway on pipe errors.
Editor v2 will handle this in a better way, if we ever get to release that.
The problem is that we usually return errors directly, and this specific callback doesn't really fit in... We added it very late (5 or 6 versions after the editor) and didn't move the commit finalization to this callback.
> > These warnings on the fs layer were designed to be logged server side
I think svnmucc just doesn't have the code to look at post commit errors (which are usually handed as warnings if I remember correctly)... I do remember that many versions of AnkhSVN didn't report such post commit error messages either. (Fixed years ago)
We should certainly change that and I would be +1 on backporting such a fix to 1.9 (and if possible 1.8).
To keep translations easy I would recommend trying if we can just copy &paste some message support from 'svn'.
This is an archived mail posted to the Subversion Dev mailing list.