[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fsfs: Segfault when rep line lists the all-zeroes checksum

From: Stefan Fuhrmann <stefan2_at_apache.org>
Date: Sat, 10 Sep 2016 20:50:28 +0200

On 08.09.2016 18:51, Daniel Shahaf wrote:
> Stefan Fuhrmann wrote on Thu, Sep 08, 2016 at 17:51:47 +0200:
>> It appears that it might be very hard to get such data into the
>> repository because we use the same parser function in e.g. the
>> network layer and the editor drivers. Not sure we all for MD5s etc.
>> to be missing in all relevant places.
> Let's get this function to return a non-NULL svn_checksum_t object for
> the all-zeroes checksum when we next revv it. (This would be a better
> interface since it would have fewer special cases.)
That would make sense. Although I would hesitate
to revv the API if that was the only change: We call
it in ~30 places and probably use the current quirk
to provide backward compatibility with old clients
and such. Migrating these invocations seems risky.

-- Stefan^2.
Received on 2016-09-10 20:50:39 CEST

This is an archived mail posted to the Subversion Dev mailing list.