[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fsfs: Segfault when rep line lists the all-zeroes checksum

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 8 Sep 2016 16:51:22 +0000

Stefan Fuhrmann wrote on Thu, Sep 08, 2016 at 17:51:47 +0200:
> It appears that it might be very hard to get such data into the
> repository because we use the same parser function in e.g. the
> network layer and the editor drivers. Not sure we all for MD5s etc.
> to be missing in all relevant places.

Let's get this function to return a non-NULL svn_checksum_t object for
the all-zeroes checksum when we next revv it. (This would be a better
interface since it would have fewer special cases.)

> That said, it is at least conceivable that some all-0 SHA1 snug in
> in an earlier version (1.5?) as a result of some inconsistent code.
> Those occurrences would be dormant and inconsequential pre 1.9
> and they should stay that way. Therefore, I proposed r1759686
> for backporting.
>
> -- Stefan^2.

Thanks,

Daniel
Received on 2016-09-08 18:52:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.