[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1757532 - /subversion/trunk/subversion/mod_dav_svn/repos.c

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Wed, 24 Aug 2016 21:07:18 +0300

Bert Huijben <bert_at_qqmail.nl> writes:

> Nice fix :-)
>
> Do you have any numbers on the resulting memory usage compared to the
> previous version. I would imagine that this could really help on updates
> with a lot of files, especially on threaded apache.

Thanks!

The difference is 32 bytes per every svn_stream_write() call that's done
while handling the request. A skelta-style update for 700 MB of deltified
contents (one file) now requires 2.5 MB less memory.

This isn't a lot, but I think it's a nice thing to have.

Another reason for this change is that every created apr_bucket_brigade
adds a pool cleanup handler, and keeping an unnecessary pile of handlers
just didn't feel right.

Regards,
Evgeny Kotkov
Received on 2016-08-24 20:07:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.