[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1757532 - /subversion/trunk/subversion/mod_dav_svn/repos.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 24 Aug 2016 16:50:10 +0200

> -----Original Message-----
> From: kotkov_at_apache.org [mailto:kotkov_at_apache.org]
> Sent: woensdag 24 augustus 2016 16:43
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1757532 -
> /subversion/trunk/subversion/mod_dav_svn/repos.c
>
> Author: kotkov
> Date: Wed Aug 24 14:43:21 2016
> New Revision: 1757532
>
> URL: http://svn.apache.org/viewvc?rev=1757532&view=rev
> Log:
> In mod_dav_svn, rewrite the code responsible for answering to GET requests
> with a specified delta base, so that it would reuse a single bucket brigade.
>
> This gets rid of the unbounded memory usage caused by creating a new bucket
> brigade per *every* call of the svn_stream_write(). The bucket brigades
> were allocated in the request pool.

Nice fix :-)

Do you have any numbers on the resulting memory usage compared to the previous version.
I would imagine that this could really help on updates with a lot of files, especially on threaded apache.

(The other patch handles the checkout case)

        Bert
Received on 2016-08-24 16:50:28 CEST

This is an archived mail posted to the Subversion Dev mailing list.