[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1755486 - in /subversion/trunk/subversion: include/svn_io.h libsvn_fs/fs-loader.c libsvn_repos/config_pool.c libsvn_subr/io.c libsvn_subr/stream.c tests/libsvn_fs/fs-test.c tests/libsvn_subr/stream-test.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 17 Aug 2016 16:23:57 +0000

Ivan Zhakov wrote on Wed, Aug 17, 2016 at 19:09:53 +0300:
> I've tried to improve docstring in r1756647.

Looks great.

> >> + * Use @a scratch_pool for temporary allocations and @a result_pool
> >> + * to allocate @a *checksum.
> >> + *
> >> + * @since New in 1.10.
> >> + */
> >> +svn_error_t *
> >> +svn_stream_checksum(svn_checksum_t **checksum,
> >
> > This interface seems very similar to svn_stream_checksummed(), both in
> > name and in functionality.
> >
> I don't see problem here, but I could suggest name it as
> svn_stream_contents_checksum(). What do you think?

+1, that's harder to confuse with svn_stream_checksummed2() and
analogous to svn_stream_contents_same2().

Thanks,

Daniel
Received on 2016-08-17 18:24:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.