On 8/7/2016 20:27, Stefan Sperling wrote:
> On Sun, Aug 07, 2016 at 08:23:58PM +0200, Stefan Sperling wrote:
>> On Sun, Aug 07, 2016 at 02:08:35PM +0200, Stefan wrote:
>>> the attached patch is the outcome of talking with jcorval on IRC about a
>>> test suite issue on Windows (release builds) in SVN 1.8. It resolves the
>>> fact that the tests will be interrupted on Windows by a Windows popup
>>> upon an abort()-call.
>>> Atm this is triggered for the 1.8 test suite for the move-test (no 8)
>>> which is marked as XFail and triggers an SVN_ERR_ASSERT() and therefore
>>> breaks fully automated tests.
>> I'm not a windows person but this looks reasonable to me. +1
> Forgot to mention: If this is a 1.8-only fix, I'd suggest you create
> a branch of 1.8.x and commit your patch there, and then nominate your
> branch in the 1.8.x/STATUS file (you can add my +1 to the nomination).
I'd certainly propose to apply the patch to trunk as well.
The reasoning would be that any code which triggers an abort-call should
be detected automatically by the test suite and not interrupt the test
run (waiting for some user interaction). So while atm no other case
seems to trigger the problem, it'd certainly improve the test facility
and prevent future problems the next time some added test (or code
change) triggers an abort() as part of running a test.
Received on 2016-08-07 21:45:43 CEST