[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Resolve testsuite interruption in SVN 1.8

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Sun, 7 Aug 2016 22:16:31 +0300

On 7 August 2016 at 21:27, Stefan Sperling <stsp_at_elego.de> wrote:
> On Sun, Aug 07, 2016 at 08:23:58PM +0200, Stefan Sperling wrote:
>> On Sun, Aug 07, 2016 at 02:08:35PM +0200, Stefan wrote:
>> > Hi,
>> >
>> > the attached patch is the outcome of talking with jcorval on IRC about a
>> > test suite issue on Windows (release builds) in SVN 1.8. It resolves the
>> > fact that the tests will be interrupted on Windows by a Windows popup
>> > upon an abort()-call.
>> >
>> > Atm this is triggered for the 1.8 test suite for the move-test (no 8)
>> > which is marked as XFail and triggers an SVN_ERR_ASSERT() and therefore
>> > breaks fully automated tests.
>>
>> I'm not a windows person but this looks reasonable to me. +1
>
> Forgot to mention: If this is a 1.8-only fix, I'd suggest you create
> a branch of 1.8.x and commit your patch there, and then nominate your
> branch in the 1.8.x/STATUS file (you can add my +1 to the nomination).
I'm not sure that we should add handling of new environment variable
in patch release.

-- 
Ivan Zhakov
Received on 2016-08-07 21:16:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.