[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1743236 - in /subversion/trunk/subversion/tests/cmdline: merge_tests.py svntest/actions.py svntest/tree.py

From: Stefan Fuhrmann <stefan2_at_apache.org>
Date: Thu, 19 May 2016 16:42:12 +0200

On 13.05.2016 19:51, Evgeny Kotkov wrote:
> Stefan Fuhrmann<stefan2_at_apache.org> writes:
>>> The new condition looks fairly suspicious.
>> Sure, but no worse than before.
> I think it's actually worse than before, as now it looks like this function
> was updated for Python 3, whereas in fact it gets all the special cases
> like "value[0] == '-'" wrong. And we will probably trip over this in the
> future.
Well, I only wanted to say that py3 wasn't supported
before either.
> How about doing it as in the attached patch?
That seems to work. Committed in r1743956.

Thanks for the patch!

-- Stefan^2.
Received on 2016-05-19 16:42:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.