[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1743236 - in /subversion/trunk/subversion/tests/cmdline: merge_tests.py svntest/actions.py svntest/tree.py

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Fri, 13 May 2016 20:51:44 +0300

Stefan Fuhrmann <stefan2_at_apache.org> writes:

>> The new condition looks fairly suspicious.
>
> Sure, but no worse than before.

I think it's actually worse than before, as now it looks like this function
was updated for Python 3, whereas in fact it gets all the special cases
like "value[0] == '-'" wrong. And we will probably trip over this in the
future.

How about doing it as in the attached patch?

Regards,
Evgeny Kotkov

Received on 2016-05-13 19:52:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.