[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1723900 - in /subversion/branches/fs-node-api/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs/node_compat.c libsvn_fs_fs/node.c tests/libsvn_fs/fs-test.c

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Mon, 11 Jan 2016 13:55:13 +0300

Bert Huijben <bert_at_qqmail.nl> writes:

> A quick review showed one minor issue, see inline.

[...]

>> @@ -2399,6 +2422,17 @@ svn_fs_file_length(svn_filesize_t *lengt
>> * @since New in 1.6.
>> */
>> svn_error_t *
>> +svn_fs_file_checksum2(svn_checksum_t **checksum,
>> + svn_checksum_kind_t kind,
>> + svn_fs_node_t *root,
>> + svn_boolean_t force,
>> + apr_pool_t *pool);
>
> Wrong argument name here.
> (And the @since should have moved to the legacy function, etc.)

Thanks for the review. Should be fixed by r1724002 and r1724003.

Regards,
Evgeny Kotkov
Received on 2016-01-11 11:55:41 CET

This is an archived mail posted to the Subversion Dev mailing list.