[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1705843 - in /subversion/trunk/subversion: libsvn_client/externals.c tests/cmdline/externals_tests.py

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Mon, 26 Oct 2015 13:42:01 +0300

On 26 October 2015 at 13:00, Bert Huijben <bert_at_qqmail.nl> wrote:
>> -----Original Message-----
>> From: Ivan Zhakov [mailto:ivan_at_visualsvn.com]
>> Sent: maandag 26 oktober 2015 09:05
>> To: dev_at_subversion.apache.org; Bert Huijben <bert_at_qqmail.nl>
>> Subject: Re: svn commit: r1705843 - in /subversion/trunk/subversion:
>> libsvn_client/externals.c tests/cmdline/externals_tests.py
>
>
>> ]]]
>> See attached patch.
>>
>> Otherwise error message could be confusing, in some cases. For example
>> if svn_wc__external_remove() return SVN_ERR_CANCELED error message
>> will be something like:
>> [[[
>> The external '%s' defined in %s at '%s' cannot be checked out because
>> '%s' is already a versioned path.
>> The operation was interrupted
>> ]]]
>
> I didn't really answer your mail:
>
> + 0.5 on the patch.
>
> I think either way would work. If you like to see it changed before the backport, feel free to add my +1 on your patch.
>
I've committed my patch in r1710558 and going to add to backport now.

-- 
Ivan Zhakov
Received on 2015-10-26 11:42:36 CET

This is an archived mail posted to the Subversion Dev mailing list.