RE: svn commit: r1705843 - in /subversion/trunk/subversion: libsvn_client/externals.c tests/cmdline/externals_tests.py

> -----Original Message-----
> From: Ivan Zhakov [mailto:ivan_at_visualsvn.com]
> Sent: maandag 26 oktober 2015 09:05
> To: dev_at_subversion.apache.org; Bert Huijben <bert_at_qqmail.nl>
> Subject: Re: svn commit: r1705843 - in /subversion/trunk/subversion:
> libsvn_client/externals.c tests/cmdline/externals_tests.py

> ]]]
> See attached patch.
>
> Otherwise error message could be confusing, in some cases. For example
> if svn_wc__external_remove() return SVN_ERR_CANCELED error message
> will be something like:
> [[[
> The external '%s' defined in %s at '%s' cannot be checked out because
> '%s' is already a versioned path.
> The operation was interrupted
> ]]]

I didn't really answer your mail:

+ 0.5 on the patch.

I think either way would work. If you like to see it changed before the backport, feel free to add my +1 on your patch.

        Bert
Received on 2015-10-26 11:01:25 CET