[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1707196 - /subversion/trunk/subversion/libsvn_subr/stream.c

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Wed, 7 Oct 2015 15:04:51 +0200

On Wed, Oct 7, 2015 at 2:57 PM, Stefan Fuhrmann <
stefan.fuhrmann_at_wandisco.com> wrote:

> On Wed, Oct 7, 2015 at 2:47 PM, Julian Foad <julianfoad_at_gmail.com> wrote:
>
>> Stefan wrote:
>> > I guess the correct way of doing this is revert Ivan's
>> > change and apply something like the attached patch.
>> Ivan wrote:
>> > Here is the patch that I wanted commit later. What do you think?
>>
>> I am not interested in reviewing any more patches that tweak just one
>> of the implementations. If you (anybody) want to do something, please
>> combine the two functions into one implementation, and then I will be
>> interested in reviewing the (single) implementation.
>>
>
> Alright, here you go.
>

Ugh, pitfall: svn_string_from_stream closes the
stream after reading it. Updated patch.

-- Stefan^2.

Received on 2015-10-07 15:05:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.