[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1707196 - /subversion/trunk/subversion/libsvn_subr/stream.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Wed, 7 Oct 2015 15:58:24 +0300

On 7 October 2015 at 15:47, Julian Foad <julianfoad_at_gmail.com> wrote:
> Stefan wrote:
>> I guess the correct way of doing this is revert Ivan's
>> change and apply something like the attached patch.
> Ivan wrote:
>> Here is the patch that I wanted commit later. What do you think?
>
> I am not interested in reviewing any more patches that tweak just one
> of the implementations. If you (anybody) want to do something, please
> combine the two functions into one implementation, and then I will be
> interested in reviewing the (single) implementation.
>
Merging svn_stringbuf_from_stream() and svn_stringbuf_from_stream()
implementations is completely ortogonal from my point of view.

But I really don't understand what was your point in r1707196 review
if you are not interested in review any changes to this function at
all.

-- 
Ivan Zhakov
Received on 2015-10-07 14:58:54 CEST

This is an archived mail posted to the Subversion Dev mailing list.