Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

Branko Čibej <brane_at_wandisco.com> writes:

>> And I have the JavaHL bits done but now I have to leave in 10 minutes,
>> which isn't enough time to review and write the log message. Will commit
>> this evening.
>
> r1688273; I propose we add it to the existing backport proposal.

From a quick glance, r1688273 looks good to me — apart from a couple of
typos in the documentation:

+/**
+ * Create a new object and store the Java object.
+ * @param notify global reference to the Java object
+ */
+ReposVerifyCallback::ReposVerifyCallback(jobject verify_cb)

(...)

+ /**
+ * Implementation of the svn_repos_verify_callback_t API.
+ *
+ * @param baton notification instance is passed using this parameter
+ * @param notify all the information about the event
+ * @param pool An APR pool from which to allocate memory.
+ */
+ static svn_error_t * callback(void *baton,
+ svn_revnum_t revision,
+ svn_error_t *verify_err,
+ apr_pool_t *scratch_pool);

(...)

+ * This callback method is invoked every time {@link ISVNRepos#verify}
+ * encounters and error.

Do you plan on voting for the corresponding group? If yes, could you please
extend the nomination with this JavaHL change? I am then going to look into
it more carefully and will update my vote accordingly.

Regards,
Evgeny Kotkov
Received on 2015-06-29 22:54:17 CEST