[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

From: Branko Čibej <brane_at_wandisco.com>
Date: Tue, 16 Jun 2015 12:17:11 +0200

On 15.06.2015 20:54, Evgeny Kotkov wrote:
> Branko Čibej <brane_at_wandisco.com> writes:
>
>> Evgeny, please take a look at r1684940.
>>
>> I don't really like the fact that with this change and 'svnadmin
>> --keep-going --quiet', the text "Error verifying revision N" gets printed
>> to stderr; but I couldn't think of a better way to join the error to the
>> revision it was emitted for. I'd love to find a better solution.
> After giving this change a look, I cannot get rid of the feeling that what we
> are doing here is just adding different workarounds for the API issues, e.g.,
> booleans like b->silent_errors or b->silent_running. I should also say that
> I find the b->feedback_stream manipulations questionable, because now, for
> instance, we write warnings to either stdout or stderr depending on the --quiet
> argument.

Yes, that's questionable: However, I'll point out that /all/ the
svnadmin commands have the same problem: all notifications go to stdout,
even warnings and errors. IMO, we should change that and really always
send warnings and errors to stderr, which means changing the notify
callback in svnadmin.

The scope of that is somewhat bigger than this discussion of 'svnadmin
verify', but we may as well look at fixing all of svnadmin's error
reporting in 1.9 as long as we're looking at it; it wouldn't really be
that big a change overall.

-- Brane
Received on 2015-06-16 12:17:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.